[mypyc] Support __pow__, __rpow__, and __ipow__ dunders #14616
Merged
+297
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike every other slot, power slots are ternary. Some special casing had to be done in generate_bin_op_wrapper() to support the third slot argument. Annoyingly, pow() also has these unique behaviours:
__rpow__
if__pow__
returnsNotImplemented
unlike binary ops.__rpow__
first if it's a subclass of the left operand and redefines__rpow__
unlike binary ops.Add in the fact it's allowed and common to only define
__(r|i)pow__
to take two arguments (actually mypy won't let you define__rpow__
to take three arguments) and the patch becomes frustratingly non-trivial.Towards mypyc/mypyc#553. Fixes mypyc/mypyc#907.